Update bindgen; Update MSRV to 1.70 #2438
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason you changed all the dependencies to use a workspace crate? It seems orthagonal to the purpose of this PR |
|
Yeah, you're right. That's a completely optional part of this change. I can revert it if you prefer. |
|
Yes, we like to keep the scope of PRs constrained
All that is necessary for evil to succeed is for good people to do nothing.
…On Tue, Aug 5, 2025, 6:37 PM Justin W Smith ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In openssl-sys/build/main.rs
<#2438 (comment)>
:
> @@ -330,7 +325,7 @@ fn validate_headers(include_dirs: &[PathBuf]) -> Version {
panic!(
"
Header expansion error:
-{:?}
+{e:?}
Sorry. I'll fix this typo.
—
Reply to this email directly, view it on GitHub
<#2438 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBEN4HTYIZCOS5WULBT3MEWZXAVCNFSM6AAAAACDFN4MP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAOBZHA4TSMJQHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
alex
reviewed
Aug 6, 2025
|
I reverted my changes related to dependency configuration. I -- EDIT: I changed the bindgen Rust target back to 1.47 to be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Description
This PR bumps the MSRV to 1.70 and updates the bindgen dependency to 0.72.0 (the latest current release).
Details: