Skip to content

Fixed two UAFs and bumped versions for release #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Conversation

alex
Copy link
Collaborator

@alex alex commented Apr 4, 2025

No description provided.

@alex alex merged commit 87085bd into sfackler:master Apr 4, 2025
79 checks passed
@alex alex deleted the uaf-fix branch April 4, 2025 12:52
This was referenced Apr 4, 2025
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Apr 15, 2025
… `Cipher::fetch` Package: openssl 0.10.70

Summary:
Reported
April 4, 2025
Issued
April 4, 2025
Package
openssl (crates.io)
Type
Vulnerability
Categories
memory-corruption
References
sfackler/rust-openssl#2390
Patched
>=0.10.72
Unaffected
<0.10.39
Affected Functions
Version
openssl::cipher::Cipher::fetch
>=0.10.39, <0.10.72
openssl::md::Md::fetch
>=0.10.39, <0.10.72
Description
When a Some(...) value was passed to the properties argument of either of these functions, a use-after-free would result.

In practice this would nearly always result in OpenSSL treating the properties as an empty string (due to CString::drop's behavior).

Reviewed By: dtolnay

Differential Revision: D72915613

fbshipit-source-id: c66dcff004a22fcd1152dd3bc7132bca57330c2e
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Apr 15, 2025
… `Cipher::fetch` Package: openssl 0.10.70

Summary:
Reported
April 4, 2025
Issued
April 4, 2025
Package
openssl (crates.io)
Type
Vulnerability
Categories
memory-corruption
References
sfackler/rust-openssl#2390
Patched
>=0.10.72
Unaffected
<0.10.39
Affected Functions
Version
openssl::cipher::Cipher::fetch
>=0.10.39, <0.10.72
openssl::md::Md::fetch
>=0.10.39, <0.10.72
Description
When a Some(...) value was passed to the properties argument of either of these functions, a use-after-free would result.

In practice this would nearly always result in OpenSSL treating the properties as an empty string (due to CString::drop's behavior).

Reviewed By: dtolnay

Differential Revision: D72915613

fbshipit-source-id: c66dcff004a22fcd1152dd3bc7132bca57330c2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants