fix/prevent_button_spam_on_scroll_to_replied_message - and VisibleMessageViews in general #983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents button spam via a generic per-VisibleMessageView spam prevention mechanism for
onPress(event: MotionEvent)
.Also added a spam-filtering
onClickListener
(currently unused but potentially useful in the future) based on code provided by @ThomasSession .The reason for the generic-VisibleMessageView spam prevention rather than an onClickListener is that
ConversationActivityV2.handlePress
warns us against directly adding onClickListeners to views as it will interfere with gestures such as drag-to-reply: