fix/QA882 voice message duration on android 9 API 28 #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to miscalculate it on older Android versions
|
|
||
| // Pass through a flag regarding whether this is an outgoing voice message to the success handler which | ||
| // will skip updating the final voice message duration if so (older android APIs <= 28 can miscalculate it). | ||
| val isOutgoingVoiceMessage = message.isSenderSelf && attachment.voiceNote |
There was a problem hiding this comment.
Aren't we always the sender when we upload attachments?
| @@ -109,25 +114,30 @@ class AttachmentUploadJob(val attachmentID: Long, val threadID: String, val mess | |||
| return Pair(key, UploadResult(id, "${server}/file/$id", digest)) | |||
| } | |||
|
|
|||
| private fun handleSuccess(dispatcherName: String, attachment: SignalServiceAttachmentStream, attachmentKey: ByteArray, uploadResult: UploadResult) { | |||
| private fun handleSuccess(dispatcherName: String, attachment: SignalServiceAttachmentStream, attachmentKey: ByteArray, uploadResult: UploadResult, isOutgoingVoiceMessage: Boolean) { | |||
There was a problem hiding this comment.
Why do we need that flag when you already have an attachment below with a voiceNote property?
There was a problem hiding this comment.
Good point - used voiceNote property instead.
ThomasSession
approved these changes
Feb 26, 2025
AL-Session
deleted the
fix/QA882_voice_message_duration_on_android_9_api_28
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older Android versions such as API 28 on some devices the final duration of a voice message can be miscalculated due to legacy codec flakiness.
This means that we record a voice message, set the correct interim duration during upload, and then set an incorrect duration on successful upload.
The fix? Don't set the final upload duration on outgoing voice messages as the interim duration set during upload is always correct.