Fix/attachment filename finetuning #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u have one then external share via session
…r things - will need to rework this in 2025 =/
… of links now, but not images at present
…branch's PassphrasePromptActivity.kt
…Activity, amongst other things
…hat lack a filename
…ilename from the attachment
… that provide null filenames
… generation - should be very comprehensive now
Removed logic from libsession Sanitising file names before saving them to storage Made sure we don't displa a date when getting filename from Slide otherwise it'll keep changing
ThomasSession
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fine-tuning of the filename synthesis when receiving attachments will null filenames:
attachment.isVoiceNoteflag (resulting appropriate filenames likeSession-VoiceMessage_<Date>.<Ext>andSession-Audio_<Date>.<Ext>,nowtimestamp in the file, and it never changes once set (so multiple saves result in the same filename - although they will get a-1,-2,-3suffix etc. if the resulting save would overwrite an existing file.