Fix/make file attachment message visible #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SessionHero01
approved these changes
Dec 17, 2024
|
QA approved - squashing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: SES-2708
Details: If a document such as a PDF was sent from Session Desktop to Session Android, and the sent document also contained some text (for example, "Here's that PDF we were talking about") - then Session Android would not show the accompanying text, only the "DocumentView" (or the pending document view with "Tap to download document" if the receiving user had not agreed to accept file downloads at that time).
This PR fixes that issue so that any accompanying text is displayed above the incoming file attachment.
Note: Session Android cannot at present sent a document and some accompanying text at the same time. Adding a document such as a PDF discards any existing text and sends the file. If we wish the behaviour to be that we can send a document and some accompanying text in the same message then this should be raised as a separate ticket.