Fix/backlog grooming june 2025 #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ost db transaction
…ing to avoid duplicates
Comment on lines
283
to
284
| val existingContent = existingNotifications.find { it.id == notificationId }?.notification?.extras?.getString(CONTENT_HASH) | ||
| val newContentHash = "${notifications[0].text}_${notifications[0].timestamp}".hashCode().toString() |
There was a problem hiding this comment.
So if we can trunk an arbitrary text as CONTENT_HASH, maybe we don't actually need to use the collision possible hashCode, but just use "${notifications[0].text}_${notifications[0].timestamp}" as CONTENT_HASH?
There was a problem hiding this comment.
Switched to a string
| val notifications = notificationState.notifications | ||
| val existingNotifications = ServiceUtil.getNotificationManager(context).activeNotifications | ||
| val existingContent = existingNotifications.find { it.id == SUMMARY_NOTIFICATION_ID }?.notification?.extras?.getString("content_hash") |
There was a problem hiding this comment.
Should this use the constant instead?
Suggested change
| val existingContent = existingNotifications.find { it.id == SUMMARY_NOTIFICATION_ID }?.notification?.extras?.getString("content_hash") | |
| val existingContent = existingNotifications.find { it.id == SUMMARY_NOTIFICATION_ID }?.notification?.extras?.getString(CONTENT_HASH) |
| val existingContent = existingNotifications.find { it.id == SUMMARY_NOTIFICATION_ID }?.notification?.extras?.getString("content_hash") | ||
|
|
||
| // Create a hash based on the notification content (all messages + their timestamps) | ||
| val contentForHash = notifications.map { "${it.text}_${it.timestamp}" }.joinToString("|") |
There was a problem hiding this comment.
Might be good to extract the way to construct the hash for reuse
There was a problem hiding this comment.
True, I moved it to a function
SessionHero01
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-3950 - Fixes to received and sent timestamps in message info
SES-2359 - Reworked video thumbnail creation to avoid race condition during db transaction
SES-4024 - Respecting the system's 12 vs 24h format
SES-2582 - Reworking notifications to allow emoji reaction notifications on outgoing messages.
Also cleaned up and reworked the overall notification logic to also avoid duplicates.