Feature/expired attachments #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending/Expired attachments now use different icons for different types Consistent padding and styling for bubbled control messages (call cm, deleted message, pending/expired attachments)
…sibility now Handling loading and failed state in attachment controls
…ousel if the image isn't downloaded
…the message details
Also added a new debug menu item to "untrust" attachments
| ViewVisibleMessageContentBinding.inflate(LayoutInflater.from(it)).mainContainerConstraint.apply { | ||
| factory = { context -> | ||
| // Inflate the view once | ||
| ViewVisibleMessageContentBinding.inflate(LayoutInflater.from(context)).mainContainerConstraint |
There was a problem hiding this comment.
Although it's existing code I think it's better to use the rootView instead of a specific view so you don't accidentally move that view off the root:
Suggested change
| ViewVisibleMessageContentBinding.inflate(LayoutInflater.from(context)).mainContainerConstraint | |
| ViewVisibleMessageContentBinding.inflate(LayoutInflater.from(context)).root |
Comment on lines
90
to
92
| (context.contentResolver.observeChanges(DatabaseContentProviders.Conversation.getUriForThread(messageRecord.threadId)) as Flow<*>) | ||
| .onStart { emit(Unit) } | ||
| .collect{ |
There was a problem hiding this comment.
Since we have changed the flow source, do you think we should add in some debounces?
There was a problem hiding this comment.
Added a debounce
SessionHero01
approved these changes
Mar 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-3518 - Changes to the attachment control.
View Jira ticket for details as a fair bit has changed visually including in the messages, control messages, quotes, message details screen.