Support type=text and type=color Input Pseudo Element Selector
#198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stevennovaryo <[email protected]>
Signed-off-by: stevennovaryo <[email protected]>
stevennovaryo
force-pushed
the
input-text-internal-pseudo-selector
branch
from
80ec17c to
591932e
Compare
stevennovaryo
commented
Jun 16, 2025
Comment on lines
-107
to
-112
| // Gecko definitely has pseudo-elements with style attributes, like | ||
| // ::-moz-color-swatch. | ||
| debug_assert!( | ||
| cfg!(feature = "gecko") || style_attribute.is_none() || pseudo_element.is_none(), | ||
| "Style attributes do not apply to pseudo-elements" | ||
| ); |
There was a problem hiding this comment.
We are also allowing style attributes for pseudo element. Notice that, in Servo, this will applies only for the pseudo element with a concrete element behind it (i.e. implemented pseudo element).
|
Could you help with the review of the companion PR as well? Thank you! @xiaochengh |
xiaochengh
reviewed
Jun 16, 2025
style/servo/selector_parser.rs
Outdated
| @@ -190,7 +202,7 @@ impl PseudoElement { | |||
| /// Whether this pseudo-element is the ::-moz-color-swatch pseudo. | |||
There was a problem hiding this comment.
Suggested change
| /// Whether this pseudo-element is the ::-moz-color-swatch pseudo. | |
| /// Whether this pseudo-element is the ::-servo-input-color-swatch pseudo. |
Signed-off-by: stevennovaryo <[email protected]>
|
I suppose both of the changes for pseudo element in Stylo and Servo is ready to be merged, could someone with a permission help with the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
::-servo-text-control-inner-editor,::-servo-text-control-inner-container,::-servo-text-control-placeholder, and::-servo-input-color-swatchpseudo element selector supporting the implementation of oftype=textandtype=colorinput element.These selectors would have a lazy cascade type. Additionally, implement
PseudoElement::is_color_swatchfor::-servo-input-color-swatchwhich would prevent the tampering of its background color .Stylo companion of servo/servo#37427.