Export AsciiSets and add some links to standards to AsciiSets documentation #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 12, 2025 15:01
This allows to re-use the AsciiSets for users of this library. Having the AsciiSets public helps to update Urls. For example `set_password` only allows to set utf-8 passwords. Setting a new 8-bit, non-utf-8 password requires to percent-encode it beforehand. So one had to rebuild the `USERINFO` AsciiSet to encode it. To avoid requiring such duplications, we make the AsciiSets public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to re-use the AsciiSets for users of this library.
Having the AsciiSets public helps to update Urls.
For example
set_passwordonly allows to set utf-8 passwords. Setting a new 8-bit,non-utf-8 password requires to percent-encode it beforehand. So one had
to rebuild the
USERINFOAsciiSet to encode it. To avoid requiringsuch duplications, we make the AsciiSets public.