perf: make parse_scheme slightly faster #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
=======================================
Coverage ? 79.98%
=======================================
Files ? 24
Lines ? 4287
Branches ? 0
=======================================
Hits ? 3429
Misses ? 858
Partials ? 0 ☔ View full report in Codecov by Sentry. |
lucacasonato
approved these changes
Feb 8, 2025
| @@ -398,15 +398,14 @@ impl<'a> Parser<'a> { | |||
| } | |||
|
|
|||
| pub fn parse_scheme<'i>(&mut self, mut input: Input<'i>) -> Result<Input<'i>, ()> { | |||
| if input.is_empty() || !input.starts_with(ascii_alpha) { | |||
| if !input.starts_with(ascii_alpha) { | |||
There was a problem hiding this comment.
Can you add a comment that starts_with will also fail for empty strings?
There was a problem hiding this comment.
Added a comment and unit test.
valenting
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids a check that's already covered by another check and avoids doing a
is_ascii_uppercase()check into_ascii_lowercase()when we know the character is lowercase.Before:
After: