-
Notifications
You must be signed in to change notification settings - Fork 348
perf: remove heap allocation in parse_query #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
=======================================
Coverage ? 80.22%
=======================================
Files ? 24
Lines ? 4258
Branches ? 0
=======================================
Hits ? 3416
Misses ? 842
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Also updates parse_fragment to work similarly to how parse_query works now where it operates on longer string slices for percent decoding, which helps to not have to do that for every character.
Before:
After: