Migrate to CloudFunctions v1 API. #165

mather · 2019-04-23T09:32:29Z

Motivation

We should use v1 API asap.

The Cloud Functions v1beta2 API is deprecated. To avoid potential service disruptions, please use the Cloud Functions v1 API instead.
https://cloud.google.com/functions/docs/api-migration

Changes

location property migrate to parent.
Use entryPoint property to specify handler function.
Use function property for stage-distinct function name to avoid confusion of function name in GCP console and confliction of http event endpoint URL.

Related Issues

#105

- 'location' property migrate to 'parent'. - Use 'entryPoint' property to specify handler function. - Use 'function' property for stage-distinct function name.

mather · 2019-06-14T05:44:10Z

@pmuens Is this plugin no more maintained?

davidjb99 · 2019-06-18T20:32:35Z

Would be good to get this merged...

dee-me-tree-or-love · 2019-08-23T08:16:03Z

Awesome, really looking forward to this!
This would also then need the doc updates here right?
https://serverless.com/framework/docs/providers/google/

mather · 2019-09-04T01:03:46Z

This would also then need the doc updates here right?
https://serverless.com/framework/docs/providers/google/

I think so.

haflinger · 2019-12-13T14:32:33Z

Hi, is this plugin maintained ?

about0 · 2020-03-10T15:17:04Z

Hey! Any update?

paladiy · 2020-03-11T17:15:45Z

Hey, are you planning to move this PR forward? Google is pushing people to migrate from beta API

nahpeps · 2020-03-12T07:28:10Z

@mather Any chance you solve the conflicts in this branch, so that it may can get finally merged?

ishallbethat · 2020-03-13T08:00:15Z

Can please help get it merged asap ?

ishallbethat · 2020-03-13T08:01:09Z

Google sent notification to force use v1.
Hello Google Cloud Functions Customer,

In June 2018, we announced Cloud Functions v1beta2 API version will be shut down on December 4, 2018. In order to give customers more time to migrate, we extended the deadline and we are now writing to let you know that the Google Cloud Functions v1beta2 API version will be shut down on April 15, 2020.

We are writing to remind you that your projects have recently made calls to the Cloud Functions v1beta2 API. Please upgrade to Cloud Functions v1 API by April 15, 2020. Google Cloud Functions v1 API has been available since October 2017.

ishallbethat · 2020-03-17T09:58:07Z

@mather can you please help resolve the conflicts and have this PR merged ? we're in really need to use v1 cloudfunction.

Conflicts: info/lib/displayServiceInfo.js package/lib/compileFunctions.js package/lib/compileFunctions.test.js

mather · 2020-03-21T10:04:49Z

I have resolved conflicts. Anyone can review this PR?

mather · 2020-03-22T15:01:25Z

When does Coveralls finish coverage tests...?

medikoo · 2020-03-22T20:57:49Z

@mather We're going to take this now. I understand it's a breaking change (?)

mather · 2020-03-24T05:37:10Z

It seems passed coverage tests already 🤔
https://coveralls.io/builds/29518088

ishallbethat · 2020-03-25T02:58:03Z

Why it still says merging is blocked ? @KhadijaBenAmmar @medikoo

medikoo · 2020-03-25T03:00:21Z

@IamGabrielWu I'm happy to merge and publish it now.

There's just one thing I want to be sure of:

I understand that it's a (semver wise) breaking change, and requires bump of major to v3 (?)

mather · 2020-03-25T05:45:31Z

@medikoo

requires bump of major to v3 (?)

Umm. I think this is minor update because this update doesn't have any interface modification on user side.

medikoo · 2020-03-25T22:17:49Z

It's published with v2.4.2 Sorry for delay!

paladiy · 2020-03-26T01:12:50Z

@medikoo Thank you for moving this forward.

I've already tried to upgrade our existing GCFs to new version and got error:

Resource types cannot be changed, previous (cloudfunctions.v1beta2.function) -> updated (gcp-types/cloudfunctions-v1:projects.locations.functions)

Googling around did not pointed to anything, but seems like it is because of the version change. Do you have any idea what could be a reason of this issue?

medikoo · 2020-03-26T01:20:12Z

Do you have any idea what could be a reason of this issue?

It might be then that it requires creation of a stack from a start (I'm not that familiar with Google Cloud), but if it's the case. then this change should be reverted in context of v2, and published with v3 as breaking.

Before I do that, I'd love other users to confirm

paladiy · 2020-03-26T01:21:21Z

yes, seems like it is the case, I've just tried to deploy function with different name (meaning create new one) and it worked well. thx

mather · 2020-03-27T05:30:39Z

then this change should be reverted in context of v2, and published with v3 as breaking.

Sure.
Sorry for not considering migration in production environment.

bao1018 · 2020-03-27T13:47:10Z

Thanks for the workaround, we will try to research solution to fix that migration challenge @paladiy

ishallbethat · 2020-03-30T07:34:50Z

anybody gets this error after 2nd time deployment using this v1 api ?
{"ResourceType":"gcp-types/cloudfunctions-v1:projects.locations.functions","ResourceErrorCode":"400","ResourceErrorMessage":{"code":400,"message":"Invalid JSON payload received. Unknown name \"location\" at 'function': Cannot find field.","status":"INVALID_ARGUMENT","details":[{"@type":"type.googleapis.com/google.rpc.BadRequest","fieldViolations":[{"field":"function","description":"Invalid JSON payload received. Unknown name \"location\" at 'function': Cannot find field."}]}],"statusMessage":"Bad Request","requestPath":"https://cloudfunctions.googleapis.com/v1/projects/<project name>/locations/us-central1/functions/<function name>","httpMethod":"PATCH"}}

ishallbethat · 2020-03-30T08:08:51Z

I raised a PR https://github.com/serverless/serverless-google-cloudfunctions/pull/204/files

…)" This reverts commit 59fe8ce.

xerosanyam · 2020-07-01T08:30:32Z

Got error "The GCF v1beta2 API is deprecated"

Solved by

npm install serverless-google-cloudfunctions@latest
Following Option-1 of migration guide, from here: https://github.com/serverless/serverless-google-cloudfunctions/blob/HEAD/MIGRATION_GUIDE.md

Migrate to CloudFunctions v1 API.

1729aa0

- 'location' property migrate to 'parent'. - Use 'entryPoint' property to specify handler function. - Use 'function' property for stage-distinct function name.

Merge branch 'master' into feature/migrate-to-cloudfunctions-v1

9260a9c

Conflicts: info/lib/displayServiceInfo.js package/lib/compileFunctions.js package/lib/compileFunctions.test.js

KhadijaBenAmmar approved these changes Mar 21, 2020

View reviewed changes

medikoo self-assigned this Mar 22, 2020

medikoo merged commit 59fe8ce into serverless:master Mar 25, 2020

mather deleted the feature/migrate-to-cloudfunctions-v1 branch March 26, 2020 01:17

This was referenced Mar 29, 2020

Failed to Update the Existing Cloud Function through v2.4.2 #202

Closed

Cloud function migration issue when update to Google v1 api #203

Closed

bao1018 mentioned this pull request Mar 31, 2020

Migration Issue fix for Google API v1beta to v1 #206

Merged

zxhaaa6 added a commit to bao1018/serverless-google-cloudfunctions that referenced this pull request Apr 1, 2020

Revert "refactor: Rely on CloudFunctions v1 not v1 beta (serverless#165…

c988629

…)" This reverts commit 59fe8ce.

zxhaaa6 mentioned this pull request Apr 1, 2020

Revert "Migrate to CloudFunctions v1 API." #207

Merged

zxhaaa6 added a commit to bao1018/serverless-google-cloudfunctions that referenced this pull request Apr 1, 2020

fix: Update from reverted changes serverless#165

ea8d059

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to CloudFunctions v1 API. #165

Migrate to CloudFunctions v1 API. #165

mather commented Apr 23, 2019 •

edited

Loading

mather commented Jun 14, 2019

davidjb99 commented Jun 18, 2019

dee-me-tree-or-love commented Aug 23, 2019

mather commented Sep 4, 2019

haflinger commented Dec 13, 2019

about0 commented Mar 10, 2020

paladiy commented Mar 11, 2020

nahpeps commented Mar 12, 2020

ishallbethat commented Mar 13, 2020

ishallbethat commented Mar 13, 2020

ishallbethat commented Mar 17, 2020

mather commented Mar 21, 2020

mather commented Mar 22, 2020 •

edited

Loading

medikoo commented Mar 22, 2020

mather commented Mar 24, 2020

ishallbethat commented Mar 25, 2020

medikoo commented Mar 25, 2020

mather commented Mar 25, 2020

medikoo commented Mar 25, 2020

paladiy commented Mar 26, 2020 •

edited

Loading

medikoo commented Mar 26, 2020

paladiy commented Mar 26, 2020

mather commented Mar 27, 2020

bao1018 commented Mar 27, 2020 •

edited

Loading

ishallbethat commented Mar 30, 2020

ishallbethat commented Mar 30, 2020 •

edited

Loading

xerosanyam commented Jul 1, 2020

Migrate to CloudFunctions v1 API. #165

Migrate to CloudFunctions v1 API. #165

Conversation

mather commented Apr 23, 2019 • edited Loading

Motivation

Changes

Related Issues

mather commented Jun 14, 2019

davidjb99 commented Jun 18, 2019

dee-me-tree-or-love commented Aug 23, 2019

mather commented Sep 4, 2019

haflinger commented Dec 13, 2019

about0 commented Mar 10, 2020

paladiy commented Mar 11, 2020

nahpeps commented Mar 12, 2020

ishallbethat commented Mar 13, 2020

ishallbethat commented Mar 13, 2020

ishallbethat commented Mar 17, 2020

mather commented Mar 21, 2020

mather commented Mar 22, 2020 • edited Loading

medikoo commented Mar 22, 2020

mather commented Mar 24, 2020

ishallbethat commented Mar 25, 2020

medikoo commented Mar 25, 2020

mather commented Mar 25, 2020

medikoo commented Mar 25, 2020

paladiy commented Mar 26, 2020 • edited Loading

medikoo commented Mar 26, 2020

paladiy commented Mar 26, 2020

mather commented Mar 27, 2020

bao1018 commented Mar 27, 2020 • edited Loading

ishallbethat commented Mar 30, 2020

ishallbethat commented Mar 30, 2020 • edited Loading

xerosanyam commented Jul 1, 2020

mather commented Apr 23, 2019 •

edited

Loading

mather commented Mar 22, 2020 •

edited

Loading

paladiy commented Mar 26, 2020 •

edited

Loading

bao1018 commented Mar 27, 2020 •

edited

Loading

ishallbethat commented Mar 30, 2020 •

edited

Loading