Skip to content

Add support for 206 response with its relevant headers + add Accept-R… #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 12, 2023

Conversation

michal1106
Copy link
Contributor

…anges in general. prompt version to 2.2.1

@lopburny
Copy link
Contributor

lopburny commented Jan 7, 2023

Hi @michal1106, Looks good to me 👍
If possible, could you add simple tests for status code 206 and the headers to the file compileMethodsToS3.test.js ?

@michal1106
Copy link
Contributor Author

michal1106 commented Jan 9, 2023

@lopburny - good idea about the tests - it was actually causing other packages to fail and s3 tests have a lot of additions
all done - please review

@lopburny
Copy link
Contributor

@michal1106 I looked over the changes and they look good to me. thank you for your work👍

@lopburny lopburny merged commit df81b3d into serverless-operations:master Jan 12, 2023
@lopburny
Copy link
Contributor

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants