Skip to content

Fix selenium to use compatible versions #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

S4more
Copy link
Contributor

@S4more S4more commented Jun 8, 2023

Selenium 4.10 removed deprecated code that this library is using.
(SeleniumHQ/selenium@9f5801c).

In my case, it prevented me from running the open_application function, since it creates an instance of WebDriver and WebDriver uses the now-removed parameter desired_capabilities in order to initialize the constructor of its parent class, webdriver.Remote.

@serhatbolsu
Copy link
Owner

Can you resolve the conflict and approve again please @S4more

@HApolonio
Copy link

@S4more - Please resolve the conflicts to allow this Pull Request to be merged.

@HApolonio
Copy link

@serhatbolsu - Can this be merged now, please?

@emanlove
Copy link
Collaborator

emanlove commented May 17, 2024

Looking now @HApolonio .. Approved and merging now ..

@emanlove emanlove merged commit c8c296d into serhatbolsu:master May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants