refactor: better data fetching #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zareix
force-pushed
the
better-data-fetch
branch
from
c087623 to
b5cd3f1
Compare
Zareix
force-pushed
the
better-data-fetch
branch
from
b5cd3f1 to
9e1df97
Compare
|
Hey @Zareix! Thank you so much for this contribution! I've been wanting to do this, but I was always too bored! 😄 I'll test this and merge as soon as I can. Thanks again! |
sergi0g
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a custom hook to fetch data, to better handle loading state and add an error screen.
It’s not perfect since we need to do it our self, but we could enhance it even more by using something like react-query although this seems overkill for a single fetch