Skip to content

feat: create new snarkjs groth16 template #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Apr 4, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn compile) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

#96 improves the Verifier.sol code, but that code is auto-generated from SnarkJS templates.

What is the new behavior?

Verifiers will be generated from our custom template, which contains the latest changes (#96).

Does this introduce a breaking change?

  • Yes
  • No

@cedoor cedoor self-assigned this Apr 4, 2022
@cedoor cedoor added the feature 🚀 This is enhancing something existing or creating something new label Apr 4, 2022
@cedoor
Copy link
Member Author

cedoor commented Apr 4, 2022

@recmo could you check if everything is ok?

@cedoor cedoor merged commit 7f20423 into dev May 17, 2022
@cedoor cedoor deleted the feat/new-snarks-template branch May 17, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant