Refactor hardcoded methods, emptyFmt and testutils #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use single structure with parameters for each of the testutils handler. Update all unit tests for the Resell API.
Remove shadowing of capabilities package in unit test and use http.MethodGet instead of hardcoded value.
Use http.MethodPost instead of hardcoded value.
Use http package constants instead of hardcoded method names. Fix emptyFmt errors.
Remove hardcoded method names and use http constants.
Remove shadowing of package name in unit tests and remove hardcoded method names.
Remove hardcoded method names and use http constants.
Remove hardcoded method names and use http constants. Remove hardcoded IPv4 type in the testing fixtures.
Remove hardcoded method names and use http constants. Remove package name shadowing in tests.
Remove hardcoded method names and use http constants. Fix emptyFmt error in request_opts.
Remove hardcoded method names and use http constants.
Remove hardcoded method names and use http constants.
Remove hardcoded method names and use http constants.
Remove shadowing of net/url package, fix emptyFmt error and rephrase DoRequest inline comment.
Pass handler options by pointer to prevent copying of big structure in tests.
Change status codes in UnmarshallError to StatusOK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use standard HTTP method names from the
net/httppackage.Remove
emptyFmterrors.Refactor testutils handlers so it will use structure with parameters instead of many arguments in each handler. This structure is passed by pointer to prevent lots of copying.