Skip to content

KLAVIYO - Mapped total key in klaviyo payload #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Apr 4, 2023

What does this PR do?

This PR is to map total field in klaviyo payload as it was being skipped earlier .

Are there breaking changes in this PR?
No

Testing

  • Testing completed successfully locally

Screenshot 2023-04-04 at 3 39 21 PM

Screenshot 2023-04-04 at 3 39 42 PM

Any background context you want to provide?
No

Is there parity with the server-side/android/iOS integration components (if applicable)?
N/A

Does this require a new integration setting? If so, please explain how the new setting works
No

Links to helpful docs and other external resources
https://segment.atlassian.net/browse/STRATCONN-1977

@Innovative-GauravKochar Innovative-GauravKochar changed the title added total key KLAVIYO - Mapped total key in klaviyo payload Apr 4, 2023
@Innovative-GauravKochar Innovative-GauravKochar marked this pull request as ready for review April 4, 2023 10:13
Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You also would need to bump the klaviyo destination version in it's package.json.

@varadarajan-tw varadarajan-tw self-requested a review April 6, 2023 12:06
@varadarajan-tw varadarajan-tw self-requested a review April 11, 2023 08:24
@Innovative-GauravKochar Innovative-GauravKochar merged commit da03368 into master Apr 12, 2023
@Innovative-GauravKochar Innovative-GauravKochar deleted the strat-1977-klaviyo branch April 12, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants