-
Notifications
You must be signed in to change notification settings - Fork 268
[Smart Hashing] Cleanup #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Smart Hashing] Cleanup #2879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2879 +/- ##
==========================================
+ Coverage 78.03% 78.11% +0.07%
==========================================
Files 1050 1050
Lines 19457 19438 -19
Branches 3771 3734 -37
==========================================
Hits 15184 15184
- Misses 2968 2972 +4
+ Partials 1305 1282 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varadarajan-tw
previously approved these changes
May 2, 2025
packages/destination-actions/src/destinations/reddit-conversions-api/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
c41157d
to
bd304d5
Compare
varadarajan-tw
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup for smart hashing util.
Remove destination slugs and feature flag.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.