-
Notifications
You must be signed in to change notification settings - Fork 266
StackAdapt audience destination: Migrate destination to use mappingSchemaV2 #2874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
da9bc02
to
44bcd9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Vanessa-SSY , thanks for the PR.
Please see the inline comment regarding the change to the package.json file.
I also noticed that the snapshot tests need to be updated as they are failing. Try this command:
yarn cloud test packages/destination-actions/src/destinations/stackadapt --updateSnapshot
Finally, do you have any proof of actual testing that this works with the new API? Would you be able to demonstrate that an end-to-end is able to send data through the two updated Actions? Some screenshots should be sufficient.
Cheers!
Joe
package.json
Outdated
"chance": "^1.1.8" | ||
}, | ||
"packageManager": "[email protected]+sha512.ff4579ab459bb25aa7c0ff75b62acebe576f6084b36aa842971cf250a5d8c6cd3bc9420b22ce63c7f93a0857bc6ef29291db39c3e7a23aab5adfd5a4dd6c5d71" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Vanessa-SSY - I'm guessing you edited this file in error. Can you undo the change for this file please?
44bcd9c
to
168de37
Compare
@@ -116,5 +114,6 @@ | |||
"dependencies": { | |||
"chance": "^1.1.8", | |||
"xml-js": "^1.6.11" | |||
} | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joe-ayoub-segment I tried to reset changes in package.json but commit hook doesn't allow me to commit without running yarn install
. Once I execute this command, the changes in package.json and yarn.lock are made again. Could you help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A summary of your pull request, including the what change you're making and why.
It won't cause any issue if you keep using mapping_schema, but we want to deprecate mapping_schema at some point.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.