Added Functionaility for Custom Attributes and Subscribers API from Attentive

[duynguyen100]

Added functionaility for action destinations to support mappings of Custom Attribute and Subscribers API, Unit tested all passed!

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

• Added unit tests for new functionality
• Tested end-to-end using the local server
• [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
• [Segmenters] Tested in the staging environment
• [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@brennan

[joe-ayoub-segment]

Hi @duynguyen100 thanks for the PR.

I think I understand what you are intending to do here.
One Action is to append attributes to a user. Another Action is to subscribe a user.
Both of these Actions are invoked with an identify() call.

Are 2 different Actions really needed for this? I'm wondering if a single Action could collect all the user attributes, and would also have a field where the customer can indicate if the user should be subscribed. You could then make 2 calls to your API to update the attributes and to subscribe the user?

Also do these API calls upsert a user?
For example if a user doesn't already exist, will the customAttributes Action create the user before adding the custom attributes to the user? Same question for the subscribers API call.

I'd be happy to discuss these design questions on a call if you can't make the decision yourself.

Please also have a look at the other comments I left inline.

Best regards,
Joe

[joe-ayoub-segment]

hi @duynguyen100 - can you undo this change please? This affects the entire solution and it's a file that should be changed.

[joe-ayoub-segment]

hi @duynguyen100 . Did you mean to change this file? If not can you revert the change to this file please?

[joe-ayoub-segment]

hi @duynguyen100 . Did you mean to change this file? If not can you revert the change to this file please?

[joe-ayoub-segment]

hi @duynguyen100 . Did you mean to change this file? If not can you revert the change to this file please?

[joe-ayoub-segment]

hi @duynguyen100 . Did you mean to change this file? If not can you revert the change to this file please?

[joe-ayoub-segment]

You could add some default mappings to look for email and phone. In an identify call these would be as follows:

default: {
  phone: { '@path': '$.traits.phone'},
  email: { '@path': '$.traits.email'}
}

[joe-ayoub-segment]

If this field is limited to 2 different types of inputs, please update it as below. It will only allow payloads through which contain one of these values:

subscriptionType: {
      label: 'Subscription Type',
      description: 'Type of subscription',
      type: 'string',
      required: true,
      choices: [
        {value: "MARKETING", value: "MARKETING"},
        {value: "TRANSACTIONAL", value: "TRANSACTIONAL"}
      ], 
      default: 'MARKETING'
}

[joe-ayoub-segment]

Segment actually provides the locale of a client side device in most cases. It doesn't do this for server side SKDs though.

The locale data is usually located here in a Segment payload:

$.context.locale

The value usually looks like this: 'en-US', where the first 2 characters are the language and the last 2 characters are the country.

See https://segment.com/docs/connections/spec/common/#context

You could go with a single locale field that collects this value. You could then parse it and use it as you like in the perform() function.

For example:

locale: {
      label: 'Locale',
      description: 'User locale (language and country)',
      type: 'string',
      required:false,
      default: {'@path': '$.context.locale'}
}

[joe-ayoub-segment]

Suggested change

	description: 'Send custom attributes to Attentive.',
	description: 'Send Custom Attributes to Attentive.',

[joe-ayoub-segment]

hi @duynguyen100 is the logic here correct?

[joe-ayoub-segment]

hi again @duynguyen100 tried to yarn build the branch and got this error:

  src/destinations/attentive/customAttributes/index.ts(4,10): error TS2724: '"./types"' has no exported member named 'CustomAttribute'. Did you mean 'CustomAttributes'?
  src/destinations/attentive/subscribers/index.ts(4,35): error TS2307: Cannot find module './types' or its corresponding type declarations.

error Command failed with exit code 1.

Can you address this also please?