-
Notifications
You must be signed in to change notification settings - Fork 267
Braze regions server #2762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Braze regions server #2762
Conversation
@brennan can we get this merged please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @davidbielik can you patch this test please? We should be good to go aftwerwards.
@marinhero any suggestions on what I need to do? Tests pass for me ![]() |
Ah! I think the test snapshot might be out of date. Let's try these instructions. Let me know how it goes! |
Also, looks like this was opened right in the middle of our node 22 update. Make sure you pull the latest version of the repo so that version of the CI checks can run. |
Do you have a public link? |
Hi @davidbielik, just checking in as the next deploy is scheduled for Tuesday April 8th and would be great to have this to be a part of it. LMK if you have any questions, I'll be happy to help. Best. |
@marinhero I ran that command but no files change: ![]() |
2bc53cf
to
759ea89
Compare
Tagging this weeks on-call to look into it @sayan-das-in |
@davidbielik this appears to be a TZ issue. We either freeze the timezone within the tests or leave the prior value of the snapshot |
...tions/src/destinations/braze/updateUserProfile/__tests__/__snapshots__/snapshot.test.ts.snap
Outdated
Show resolved
Hide resolved
…Profile/__tests__/__snapshots__/snapshot.test.ts.snap
Thanks - reverted date to the previous value. |
Hi @marinhero, FYI I'm back so can run with this PR. |
Thanks @joe-ayoub-segment i removed those lines if that's easier |
New PR created here Closing this PR. |
Adds new regions to braze server destinations
Testing