Tests with data providers in parent class don't work anymore

[l-x]

Q	A
PHPUnit version	8.4.0
PHP version	7.3.9
Installation Method	Composer

Summary

Tests classes that contain a test method utilizing a data provider defined in a parent class will produce a warning.

Previous Behavior

No warnings will be shown

Current Behavior

Warning:

The data provider specified for FuTest::testFu is invalid.
Cannot instantiate abstract class AbstractFuTestCase

How to reproduce

abstract class AbstractFuTestCase extends \PHPUnit\Framework\TestCase
{
    public function dataProvider(): array
    {
        return [
            ['fu'],
            ['bar'],
        ];
    }

    /**
     * @dataProvider dataProvider
     */
    public function testFu(string $bar): void
    {
        $this->assertTrue(true);
    }
}

class FuTest extends AbstractFuTestCase
{

}

Just run the FuTest

[pavbis]

Can also confirm the issue. Just updated to 8.4.0.

[sebastianbergmann]

@Ocramius This looks like it could be related to #3836. PHPUnit tries to create an instance of AbstractFuTestCase instead of FuTest to call the data provider method on.

[Ocramius]

@sebastianbergmann basically the patch takes the parent class instead of the child class when considering an annotation, right?

[panvid]

The problem also appear on simple abstraction, see: #3881 (comment)

[sebastianbergmann]

I am not sure whether this is related to annotation parsing. Might as well be related to #3381 (or something else). I cannot look into this right now, will do so over the weekend.

[l-x]

To clarify the problem I reported: It is not necessary to put the two classes in a single file to reproduce this behaviour.

[sebastianbergmann]

@Ocramius According to git bisect, 9309062 is the first "bad commit":

$ cat run.sh               
#!/bin/sh
composer update
./phpunit --fail-on-warning /tmp/FuTest.php

$ git bisect start
$ git bisect good 8.3.5
$ git bisect bad 8.4.0
$ git bisect run ./run.sh

The contents of /tmp/FuTest.php is the example from #3879 (comment).

[gleb-svitelskiy]

Here is the bug 9309062
This is all about reflection. For example:

class Foo
{
    public function baz() {}
}

class Bar extends Foo {}

$reflectionMethod = new \ReflectionMethod('Bar', 'baz');
var_dump($reflectionMethod->getDeclaringClass()->getName());

It will be string(3) "Foo"
So it's not a good idea to get class name from declaring class.
It works before because class name passed to getDataFromDataProviderAnnotation() was received in TestUtil::getProvidedData(), not from ReflectionMethod