relax version constraints on dependencies #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless there are specific issues with a particular release of a dependency, libraries in particular should be pinned to allow minor release updates. This reduces version constraint conflicts for consumers of the library.
jwilger
commented
Jun 16, 2024
| assert {:error, "connection refused"} = TestClient.get("http://localhost:#{bypass.port}/") | ||
| assert {:error, :econnrefused} = TestClient.get("http://localhost:#{bypass.port}/") |
There was a problem hiding this comment.
I think (but am not 100% sure) that this is needed due to elixir-tesla/tesla#573.
seancribbs
reviewed
Jun 17, 2024
seancribbs
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying version constraints to allow minor release updates whenever possible makes it less likely that there will be constraint conflicts in dependent applications.