Skip to content

fix: update bug of installation with custom dataloder #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

fix: update bug of installation with custom dataloder #3331

merged 3 commits into from
May 15, 2025

Conversation

ori-kron-wis
Copy link
Collaborator

No description provided.

@ori-kron-wis ori-kron-wis self-assigned this May 15, 2025
@ori-kron-wis ori-kron-wis added custom_dataloader PR 2932 on-merge: backport to 1.3.x on-merge: backport to 1.3.x labels May 15, 2025
@codecov Codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (197c78a) to head (3c80e52).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/dataloaders/_custom_dataloders.py 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3331      +/-   ##
==========================================
- Coverage   84.02%   80.15%   -3.88%     
==========================================
  Files         197      197              
  Lines       18155    18156       +1     
==========================================
- Hits        15255    14553     -702     
- Misses       2900     3603     +703
Files with missing lines Coverage Δ
src/scvi/dataloaders/_custom_dataloders.py 91.01% <71.42%> (-0.56%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis merged commit 78f107b into main May 15, 2025
16 of 18 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request May 15, 2025
@ori-kron-wis @meeseeksmachine
Backport PR scverse#3331: update bug of installation with custom data…
16188d0 
…loder
@meeseeksmachine meeseeksmachine mentioned this pull request May 15, 2025
Merged
@ori-kron-wis ori-kron-wis changed the title update bug of installation with custom dataloder fix: update bug of installation with custom dataloder May 15, 2025
ori-kron-wis added a commit that referenced this pull request May 15, 2025
@meeseeksmachine @ori-kron-wis
Backport PR #3331 on branch 1.3.x (update bug of installation with cu…
7cae6c9 
…stom dataloder) (#3332)

Backport PR #3331: update bug of installation with custom dataloder

Co-authored-by: Ori Kronfeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ori-kron-wis ori-kron-wis

Labels
custom_dataloader PR 2932 on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ori-kron-wis