Fix pants blocks width, height and connection positions #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: RTL, figure out why we need to add 3 corner radii to the height sometimes. Thank you @NeilFraser for your help on this.
|
Looks and works great, thanks Ray! |
|
👖 |
rschamp
added a commit
that referenced
this pull request
Feb 12, 2016
Fix pants blocks width, height and connection positions
BeksOmega
pushed a commit
to BeksOmega/scratch-blocks
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: RTL
TODO: Why do we need to modify the height by 3 corner radii sometimes? (Possibly due to inaccurate NOTCH_HEIGHT)
Thank you @NeilFraser for helping me with this.
Resolves #31