Skip to content

Require JDK 17, test on JDK 21 (drop some tests having issues with JDK 17+) #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
maven: [ '3.8.8', '3.9.9' ]
java: [ '11', '17' ]
java: [ '17', '21' ]
os: [ 'ubuntu-latest', 'windows-latest' ]
runs-on: ${{ matrix.os }}
steps:
Expand Down
12 changes: 6 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ under the License.
<artifactId>maven-compiler-plugin</artifactId>
<version>3.13.0</version>
<configuration>
<release>11</release>
<release>17</release>
<compilerArgs>
<arg>-Xlint:all</arg>
<arg>-Xlint:-processing</arg>
Expand Down Expand Up @@ -272,11 +272,11 @@ under the License.
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.11.1</version>
<configuration>
<source>11</source>
<source>17</source>
<detectJavaApiLink>false</detectJavaApiLink>
<subpackages>org.scoverage.plugin</subpackages>
<links>
<link>https://docs.oracle.com/en/java/javase/11/docs/api/</link>
<link>https://docs.oracle.com/en/java/javase/17/docs/api/</link>
<link>https://maven.apache.org/shared-archives/maven-reporting-api-${maven-reporting-api.version}/apidocs/</link>
<link>https://maven.apache.org/doxia/components/doxia-archives/doxia-${doxia.version}/apidocs/</link>
<link>https://maven.apache.org/ref/${maven.version}/apidocs/</link>
Expand Down Expand Up @@ -331,7 +331,7 @@ under the License.
<excludes>
<exclude>org/scoverage/plugin/HelpMojo.java</exclude>
</excludes>
<targetJdk>11</targetJdk>
<targetJdk>17</targetJdk>
</configuration>
</plugin>

Expand Down Expand Up @@ -503,8 +503,8 @@ under the License.
<configuration>
<rules>
<requireJavaVersion>
<version>11</version>
<message>Java 11 or later required.</message>
<version>17</version>
<message>Java 17 or later required.</message>
</requireJavaVersion>
</rules>
</configuration>
Expand Down
5 changes: 1 addition & 4 deletions src/it/test_ScalaMavenPlugin_Scala2_12_JUnit/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

<properties>
<scala.compat.version>2.12</scala.compat.version>
<scala.minor.version>8</scala.minor.version> <!-- Testing that 2.12.8 is supported -->
<scala.minor.version>20</scala.minor.version>
</properties>

<build>
Expand All @@ -39,9 +39,6 @@
<plugin>
<groupId>@project.groupId@</groupId>
<artifactId>@project.artifactId@</artifactId>
<configuration>
<scalacPluginVersion>2.0.0</scalacPluginVersion> <!-- Downgrading for Scala 2.12.8 -->
</configuration>
</plugin>
</plugins>
</build>
Expand Down
2 changes: 1 addition & 1 deletion src/it/test_ScalaMavenPlugin_Scala2_12_ScalaTest/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

<properties>
<scala.compat.version>2.12</scala.compat.version>
<scala.minor.version>19</scala.minor.version>
<scala.minor.version>20</scala.minor.version>
</properties>

<build>
Expand Down
1 change: 0 additions & 1 deletion src/it/test_skip_Scala2_10/invoker.properties

This file was deleted.

45 changes: 0 additions & 45 deletions src/it/test_skip_Scala2_10/pom.xml

This file was deleted.

This file was deleted.

This file was deleted.

12 changes: 0 additions & 12 deletions src/it/test_skip_Scala2_10/validate.groovy

This file was deleted.

1 change: 0 additions & 1 deletion src/it/test_skip_Scala2_11/invoker.properties

This file was deleted.

45 changes: 0 additions & 45 deletions src/it/test_skip_Scala2_11/pom.xml

This file was deleted.

This file was deleted.

This file was deleted.

12 changes: 0 additions & 12 deletions src/it/test_skip_Scala2_11/validate.groovy

This file was deleted.

1 change: 0 additions & 1 deletion src/it/test_skip_Scala2_12_7/invoker.properties

This file was deleted.

55 changes: 0 additions & 55 deletions src/it/test_skip_Scala2_12_7/pom.xml

This file was deleted.

This file was deleted.

This file was deleted.

12 changes: 0 additions & 12 deletions src/it/test_skip_Scala2_12_7/validate.groovy

This file was deleted.

49 changes: 29 additions & 20 deletions src/it/test_skip_Scala3_1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,24 +23,33 @@
<scala.library.artifact.id>scala3-library_3</scala.library.artifact.id>
</properties>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
</plugin>
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.scalatest</groupId>
<artifactId>scalatest-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>@project.groupId@</groupId>
<artifactId>@project.artifactId@</artifactId>
</plugin>
</plugins>
</build>
<profiles>
<profile>
<id>run</id>
<activation>
<jdk>17</jdk> <!-- Only run on JDK 17, as Scala 3.1 doesn't support JDK 21 -->
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
</plugin>
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.scalatest</groupId>
<artifactId>scalatest-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>@project.groupId@</groupId>
<artifactId>@project.artifactId@</artifactId>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>