#366 - Allow registering of combined plugin/wf activity libraries #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottdurow
added a commit
that referenced
this pull request
Jun 30, 2020
* Spkl dev 191212 (#347) * Resolves #176 * Updated dependancies to v9 * 1.0.4 Updated assembly name and added dependnacy on fakeiteasy * Added support for setting all ExecutionContext properties * Fixes #218 & SetState & SetStateDynamicEntity message property of EntityMoniker (#220) * Fixes #218 * SetState & SetStateDynamicEntity use message property of EntityMoniker * Fixes #232 * Version 1.0.6 * ix dependency load error - Cannot resolve dependency to assembly 'Sy… …stem, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' because it has not been preloaded. When using the ReflectionOnly APIs, dependent assemblies must be pre-loaded or loaded on demand through the ReflectionOnlyAssemblyResolve event. site:stackoverflow.com * Fix #226: Predefined Type '' is not defined or imported (#236) Due to Visual Studio 2017 changes in how assemblies are resolved. Now project can be built using Visual Studio 2017 * Fixed typo (#280) * Fix some typos (#311) * Let OOB batch files to pass parameters like "/p" to spkl.exe * Add support for workflow base class Fix dependency load error * Fix dependency load error (#346) * ix dependency load error - Cannot resolve dependency to assembly 'Sy… …stem, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' because it has not been preloaded. When using the ReflectionOnly APIs, dependent assemblies must be pre-loaded or loaded on demand through the ReflectionOnlyAssemblyResolve event. site:stackoverflow.com * Add support for workflow base class Fix dependency load error * #308 Removed dependency on OrganizationServiceProxy that does not support OAuth * 🧹 Fixed typo and formatting * 🧹 Code formatting clean up * 🧪 Unit/Integration Test Playlists * 📦 Updated to latest nuget packages * Added FilteringService dependencies * Removed WindowsForms reference from nuget package as it's no longer included in the SDK * Updated nuget spec to depend on CoreTools 9.1.0.25 * Compare web resources content before update (#352) * Comparing WebResource content, to skip unnecessary update * Comparing WebResource content, to skip unnecessary update * Ability to specify earlybound types as array, not single string with comma separator * #354 Export command 🧹 Code formatting tidy up * Use xrm tooling for command line login prompt (#373) * #369 New Command Line Login using Xrm.Tooling * Added message about /l legacy login switch * #366 - Allow registering of combined plugin/wf activity libraries (#374) * 🐛 Pick up Release assembly when in Release mode Co-authored-by: Andy Elsmore <[email protected]> Co-authored-by: pawelgradecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #366 for where an assembly contains both plugins and wf activities. When deploying plugins, the workflow types will not be unregistered - and visa vera.
A further enhancement would be to provide a dedicated task to register plugin steps and workflow activities in one.
This PR also changes the way that we load assemblies to not use reflection - this means that the binding redirects in the app.config become important to allow loading of older assembly versions. This is because the reflection load would always require an exact match of version.