Use timeout utility instead of double-sub-shell hell #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SlouchyButton Any idea why |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hhorak
force-pushed
the
simplify-timeout
branch
from
60c8c81 to
fbc78b3
Compare
|
[test] |
hhorak
force-pushed
the
simplify-timeout
branch
from
fbc78b3 to
09eaab2
Compare
|
[test] |
hhorak
force-pushed
the
simplify-timeout
branch
from
09eaab2 to
52a1c32
Compare
|
[test] |
SlouchyButton
approved these changes
Aug 28, 2024
No, I don't think it could be a problem. Only thing to keep in mind is that it is part of |
phracek
approved these changes
Sep 2, 2024
|
[test] |
It turned out that for incremental builds for Node.js, the test always waited 10m no matter that the build finished sooner. It's not clear why it happened, but when debugging, it seemed like some weired race-condition happened that let some sleeps hang. Anyway, it's not clear whether there is a reason to not use timeout utility that seems to serve exactly for this reason.
hhorak
force-pushed
the
simplify-timeout
branch
from
52a1c32 to
fc8bf0e
Compare
|
[test] |
|
Let's get merge it and distribute to s2i-nodejs-container as first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that for incremental builds for Node.js, the test always waited 10m no matter that the build finished sooner.
It's not clear why it happened, but when debugging, it seemed like some weired race-condition happened that let some sleeps hang.
Anyway, it's not clear whether there is a reason to not use timeout utility that seems to serve exactly for this reason.