Skip to content

Improves large scale handling with Amount #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 19, 2025
Merged

Improves large scale handling with Amount #549

merged 6 commits into from
Feb 19, 2025

Conversation

mkeckmkeck
Copy link
Contributor

@mkeckmkeck mkeckmkeck commented Feb 19, 2025 •
edited
Loading

Description

  • Creates new parsing methods for larger scale
  • Use larger scale for Jackson de/serialization
  • Javadoc + minor fixes

Additional Notes

  • This PR fixes or works on following ticket(s): SE-14351

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@mkeckmkeck
Introduces new methods to parse Amount without scale limit
b976787 
- we need to add BigDecimal parsing support to NLS as well

Fixes: SE-14351
@mkeckmkeck
Extends javadoc with scaling not
df8b7f6 
- and converts to markdown

Fixes: SE-14351
@mkeckmkeck
Converts javadoc to markdown
f214e8c 
- some of them contain formatting which looks nicer using markdown
- change all to consistent within class

Fixes: SE-14351
@mkeckmkeck
Do not limit amount scale when using jackson de/serialization
a6a06b4 
Fixes: SE-14351
@mkeckmkeck
Fixes some markdown javadocs
8e682ce 
- note: autoformat works incorrectly here and changes the indention of:
    /// @param format the `NumberFormat` used to obtain the number of decimal places, the decimal format symbols
    ///               and rounding mode
in each subsequent call. imo our settings of the formatter are correct, so this might be a bug.

Fixes: SE-14351
@mkeckmkeck
Removes interface as already included inheritance of Number
8a83438 
Fixes: SE-14351
@mkeckmkeck mkeckmkeck added the 🧬 Enhancement Contains new features label Feb 19, 2025
@mkeckmkeck mkeckmkeck mentioned this pull request Feb 19, 2025
Merged
3 tasks
@sabieber sabieber merged commit 0e5d386 into develop Feb 19, 2025
4 checks passed
@sabieber sabieber deleted the feature/SE-14351_amount_scaling branch February 19, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@jmuscireum jmuscireum jmuscireum approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@idlira idlira idlira approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkeckmkeck @sabieber @jmuscireum @jakobvogel @fhaScireum @idlira