XXE soften for XMLStructuredInput #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- currently xml with an external dtd is not allowed Fixes: SIRI-1037
… setting - adds setting to ignore external dtd completely: see https://xerces.apache.org/xerces2-j/features.html#nonvalidating.load-external-dtd - so they get ignored, but the xml parsing won't fail on them - wrap this inside a little helper method to create the DocumentBuilderFactories Fixes: SIRI-1037
- settings as per: https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html - this also applies the settings "http://xml.org/sax..." already used at SAX parser to DocumentBuilder factory - and prevents entity reference expansion as documentation suggests Fixes: SIRI-1037
…dInput is prevented Fixes: SIRI-1037
- applying result.setFeature("http://xml.org/sax/features/external-parameter-entities", false) AND
result.setExpandEntityReferences(false) will result in "no-dangerous-execution" AND no exception
Fixes: SIRI-1037
idlira
approved these changes
Jan 27, 2025
fhaScireum
approved these changes
Jan 27, 2025
scireum-mbo
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapts securits setting for XML parsing. See commit messages for details.
Adds new unit tests as well.
Additional Notes
Checklist