[MRG] do not try to complete when X_source is empty #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
source_target_merge(X_source, X_target)
, if one of the twoX_source
(orX_target
) is empty then it infers what should be its default value based on the other one using the_find_y_type
function.This PR avoids this by checking the length of
sample_domain
for the emptyX_source
orX_target
. If the length is 0, then it skips the imputation.