Skip to content

[MRG] do not try to complete when X_source is empty #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

antoinecollas
Copy link
Collaborator

@antoinecollas antoinecollas commented Nov 19, 2024

When doing source_target_merge(X_source, X_target), if one of the two X_source (or X_target) is empty then it infers what should be its default value based on the other one using the _find_y_type function.
This PR avoids this by checking the length of sample_domain for the empty X_source or X_target. If the length is 0, then it skips the imputation.

@antoinecollas antoinecollas changed the title [WIP] do not try to complete when X_source is empty [TO_REVIEW] do not try to complete when X_source is empty Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (5723185) to head (ae27803).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files          61       61           
  Lines        6375     6382    +7     
=======================================
+ Hits         6202     6209    +7     
  Misses        173      173           
---- 🚨 Try these New Features:

@antoinecollas antoinecollas changed the title [TO_REVIEW] do not try to complete when X_source is empty [MRG] do not try to complete when X_source is empty Nov 19, 2024
@antoinecollas antoinecollas merged commit c5115dd into scikit-adaptation:main Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants