[TO_REVIEW] Enhancements to DomainAwareNet and Scorers to handle allow_source
arg
#258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important changes include adding support for source domains in various methods and updating the scoring mechanism to accommodate these changes.
Enhancements to
DomainAwareNet
:allow_source
parameter topredict
,predict_proba
, andscore
methods to support source domains. (skada/deep/base.py
) [1] [2] [3]check_X_domain
usage inpredict_proba
andscore
methods to handleallow_source
. (skada/deep/base.py
) [1] [2]Updates to testing and metrics:
allow_source
parameter in predictions. (skada/deep/tests/test_deep_scorer.py
)skada/deep/tests/test_deep_scorer.py
)_score
method inmetrics.py
to handleallow_source
parameter and removed outdated code. (skada/metrics.py
) [1] [2] [3]allow_source
parameter to various scoring functions and ensured compatibility with deep estimators. (skada/metrics.py
) [1] [2] [3] [4]