Skip to content

[TO_REVIEW] Bug fix when None in make_da_pipeline #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

antoinecollas
Copy link
Collaborator

Enhancement: Add compatibility with None in skada pipelines

This PR introduces support for using None within skada pipelines, similar to how scikit-learn handles it. For example:

pipe = make_pipeline(
        StandardScaler(),
        None,  # Skip step
        PCA(),
        LogisticRegression(),
)

Now, skada pipelines can also include None as a step:

pipe = make_da_pipeline(
        StandardScaler(),
        None,  # Skip step
        PCA(),
        SubspaceAlignmentAdapter(n_components=2),
        LogisticRegression(),
)

@antoinecollas antoinecollas changed the title [WIP] Bug fix when None in make_da_pipeline [TO_REVIEW] Bug fix when None in make_da_pipeline Oct 15, 2024
Copy link
Collaborator

@rflamary rflamary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would maybe test with and without the None to check that we have the same output.

@antoinecollas antoinecollas merged commit 6d9de7f into scikit-adaptation:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants