Skip to content

Fix: Dev scorer wasn't working with SourceOnly and TargetOnly #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

YanisLalou
Copy link
Collaborator

Issue:

The SourceOnly and TargetOnly methods were not functioning as expected.

Cause:

The default behavior was overriding the layer names, setting them to None, which caused the issue.

Solution:

  • Removed the default None assignment for layer names in the selectSource and selectTarget methods.

Next Steps:

  • Add relevant test cases to ensure proper functionality.

@tgnassou tgnassou merged commit 86d250d into scikit-adaptation:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants