Skip to content

CI testing environment #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsheunis opened this issue Dec 3, 2023 · 1 comment
Closed

CI testing environment #92

jsheunis opened this issue Dec 3, 2023 · 1 comment

Comments

@jsheunis
Copy link

jsheunis commented Dec 3, 2023

I see the CI only runs on ubuntu: https://github.com/scienxlab/redflag/blob/main/.github/workflows/build-test.yml

I wouldn't say its absolutely necessary, but it would probably be a good idea to run tests on all major operating systems. If not, I suggest stating that in the documentation.

Ping openjournals/joss-reviews#6065
kwinkunks added a commit that referenced this issue Dec 9, 2023
@kwinkunks
Update CI and test on all OS's
c52d3ce 
Fixes #92
@kwinkunks
Copy link
Member

Great suggestion, thank you.

Done in c52d3ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwinkunks @jsheunis