This repository was archived by the owner on Nov 24, 2018. It is now read-only.
feat: upload API #148
Closed
feat: upload API #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schickling
suggested changes
Aug 3, 2017
| @@ -3,6 +3,7 @@ import ChromeRemote from './chrome/remote' | |||
| import Queue from './queue' | |||
| import { ChromelessOptions, Cookie, CookieQuery, PdfOptions } from './types' | |||
| import { getDebugOption } from './util' | |||
| import {isArray} from "util"; | |||
There was a problem hiding this comment.
Please use single quotes & no semicolon
There was a problem hiding this comment.
sorry... auto import :/
| @@ -31,6 +31,7 @@ import { | |||
| mousedown, | |||
| mouseup, | |||
| focus, | |||
| upload | |||
| @@ -274,6 +275,14 @@ export default class Chromeless<T extends any> implements Promise<T> { | |||
| return this | |||
| } | |||
|
|
|||
| upload(selector: string, files: string[] | string): Chromeless<T> { | |||
There was a problem hiding this comment.
I think the name upload is a bit misleading since all this is doing is selecting files in a file input. Maybe rather use selectFile instead?
|
I think the name Open for discussion! |
|
Hello @schickling, selectFile and selectFiles ? |
|
closing this one due to #170 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100