WIP: Ingest treebanks from Daphne #185
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwegner
commented
Jan 3, 2024
There was a problem hiding this comment.
@jtauber This extractor came from https://github.com/scaife-viewer/ogl-pdl-annotations/blob/feature/dictionaries/pipelines/syntax_trees/ud.py and likely could be further refactored with scaife_stack_atlas/extractors/extract_hilleary_treebanks.py
The frontend now expects syntax trees to be grouped into a TextAnnotationCollection, which is currently added via set_dahpne_text_annotation_collection, but would ideally be refactored so that:
- Syntax tree collections would be subdirectories in
data/annotations/syntax-trees - Each collection would have a
metadata.yml - The ingestion script would parse a directory, read the metadata from metadata.yml and load the syntax trees specified by the metadata.yml, similar to https://github.com/scaife-viewer/beyond-translation-site/blob/ef06fe30437c6c4181a2e44b462fc8741b1be98f/backend/data/annotations/token-annotations/od-crane/metadata.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.