Skip to content

Corrected python version in installation document (Revised) #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

VijaySamant4368
Copy link
Contributor

Updated python version to be >=3.10 everywhere on the installation guide.
Resolves #1420

Correctly created the pull request from a feature branch.

@janfb janfb self-assigned this Mar 11, 2025
@janfb janfb added the docs Improvements or additions to documentation label Mar 11, 2025
@janfb janfb added this to the pre-hackathon release milestone Mar 11, 2025
@VijaySamant4368 VijaySamant4368 changed the title Corrected python version in installation document Corrected python version in installation document (Revised) Mar 11, 2025
Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (7b6cab3) to head (583d31f).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (7b6cab3) and HEAD (583d31f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (7b6cab3) HEAD (583d31f)
unittests 3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1423       +/-   ##
===========================================
- Coverage   89.38%   78.28%   -11.11%     
===========================================
  Files         119      119               
  Lines        8905     8905               
===========================================
- Hits         7960     6971      -989     
- Misses        945     1934      +989     
Flag Coverage Δ
unittests 78.28% <ø> (-11.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janfb janfb merged commit 43ae353 into sbi-dev:main Mar 11, 2025
5 checks passed
@janfb
Copy link
Contributor

janfb commented Mar 11, 2025

Congrats on your first sbi PR @VijaySamant4368! 🎉

@VijaySamant4368
Copy link
Contributor Author

Thank you @janfb , i look forward to a great contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: fix typo in installation instructions
2 participants