Fix: Escape URL before converting to URI; catch Addressable::URI::InvalidURIError

[nudded]

This allows urls with spaces in, as they were previously re-escaped (in v3.5.0)

We now also catch the Addressable::URI::InvalidURIError, as that might be raised while escaping if URI is invalid

[olleolleolle]

@nudded Thank you so much for taking the time to improve Wasabi!

I made minor detail test-related comments, you can react to them, and then we can probably get this merged. If you don't have strong feelings either way, we can merge it and move from there.

❤️

[nudded]

@olleolleolle thanks for the quick reply! I've applied your suggestions, I agree with your comments 👍

[coveralls]

Coverage decreased (-36.7%) to 61.697% when pulling 2e26c5e on nudded:fix-parser-with-escaped-urls into a62be31 on savonrb:master.

[coveralls]

Coverage increased (+0.03%) to 98.413% when pulling 4e6a4c0 on nudded:fix-parser-with-escaped-urls into a62be31 on savonrb:master.

[nudded]

@olleolleolle I rebased and fixed the specs, hopefully, that will allow for a quick release 🤞

[olleolleolle]

Looks good to me!

Thanks for all the care & effort to improve this.

[olleolleolle]

@nudded I came up with one more hurdle! It's a good one - add a CHANGELOG line in this change. (You need to rebase on master first, since I added a section there, for "Unreleased".)

If you don't get around to it, I'll make a change myself later.

[nudded]

@nudded I came up with one more hurdle! It's a good one - add a CHANGELOG line in this change. (You need to rebase on master first, since I added a section there, for "Unreleased".)

If you don't get around to it, I'll make a change myself later.

Done 🎉