Skip to content

[Java] Allow test/suitename to be optional when not using TestMetaExtension utility #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

omacranger
Copy link
Member

@omacranger omacranger commented May 15, 2025

Description

Re-allows test/suitename to be null either by default or by passing values through check options
Also returns the snapshot ID from sauceVisualCheck override without CheckOptions to be consistent

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor/improvements

Copy link
Contributor

@perf2711 perf2711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@omacranger omacranger merged commit 319eaa3 into main May 15, 2025
4 checks passed
@omacranger omacranger deleted the bugfix/testname-suitename-optional branch May 15, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants