[java] set isDisabled to true by default (make Bindings opt-in) #342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we want to make Sauce Bindings opt-in instead of opt-out.
This has the advantage of not changing default behavior when registering extension or adding rule.
This would require the user to update their CI tool to run with an environment variable or system property.
This would require the user to add
static { System.setProperty("sauce.disabled", "false") }
in order to run tests on Sauce Labs.If we have this logic in CI plugins (e.g. Jenkins), it would just work on CI. If we create IDE plugins, we just add the toggle to the Run configs or context clicks.
Now that we are making this switch, do we want to make this
sauce.enabled
instead? Probably.