-
Notifications
You must be signed in to change notification settings - Fork 16
[junit4] deprecate the superclass and implement with a rule #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9cc0cb
to
ef09581
Compare
a87d120
to
eafb433
Compare
eafb433
to
4f33668
Compare
Good news! This implementation is Thread safe! |
47c0652
to
dee7901
Compare
titusfortner
commented
Oct 17, 2024
titusfortner
commented
Oct 17, 2024
java/junit4/src/test/java/com/saucelabs/saucebindings/junit4/examples/DataCenterExample.java
Outdated
Show resolved
Hide resolved
titusfortner
commented
Oct 17, 2024
java/junit4/src/test/java/com/saucelabs/saucebindings/junit4/examples/ToggleLocalExample.java
Outdated
Show resolved
Hide resolved
titusfortner
commented
Oct 17, 2024
java/junit4/src/main/java/com/saucelabs/saucebindings/junit4/SauceBindingsWatcher.java
Show resolved
Hide resolved
titusfortner
commented
Oct 17, 2024
java/junit4/src/main/java/com/saucelabs/saucebindings/junit4/SauceBindingsWatcher.java
Outdated
Show resolved
Hide resolved
e5677e0
to
aba2b52
Compare
…for toggling local
7aaf524
to
144e7fa
Compare
144e7fa
to
f98030d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Matches JUnit 5 approach to minimize effort to update existing projects
Description
Types of Changes
Considerations