Skip to content

[junit4] deprecate the superclass and implement with a rule #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 7, 2024

Conversation

titusfortner
Copy link
Collaborator

One-line summary

Matches JUnit 5 approach to minimize effort to update existing projects

Description

  • Deprecates the old way that didn't actually work properly
  • Implements everything as a Rule which is very straightforward

Types of Changes

  • New feature (non-breaking change which adds functionality)

Considerations

  • @nadvolod do we need to update documentation for this?

@titusfortner titusfortner force-pushed the junit4_ext branch 2 times, most recently from b9cc0cb to ef09581 Compare September 24, 2024 21:29
@titusfortner titusfortner force-pushed the junit4_ext branch 2 times, most recently from a87d120 to eafb433 Compare October 4, 2024 15:24
@titusfortner
Copy link
Collaborator Author

Good news! This implementation is Thread safe!
I've updated it with the newly merged features in JUnit 5

@titusfortner titusfortner force-pushed the junit4_ext branch 2 times, most recently from e5677e0 to aba2b52 Compare November 7, 2024 01:33
@titusfortner titusfortner force-pushed the junit4_ext branch 2 times, most recently from 7aaf524 to 144e7fa Compare November 7, 2024 22:35
@titusfortner titusfortner merged commit a435b22 into main Nov 7, 2024
10 checks passed
@titusfortner titusfortner deleted the junit4_ext branch November 7, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant