Skip to content

resolves #299 python: adding support to tunnelOwner/tunnelName #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

waggledans
Copy link
Contributor

@waggledans waggledans commented Jul 17, 2024

One-line summary

Issue : #299

Description

See https://docs.saucelabs.com/dev/test-configuration-options/#tunnelowner and https://docs.saucelabs.com/dev/test-configuration-options/#tunnelname

No breaking changes. parent_tunnel and tunnel_identifier will be removed in the future.

  • Adding tunnelOwner (which is the same as parent_tunnel) to future-proof python bindings library
  • Adding tunnelName (which is the same as tunnel_identifier) to future-proof python bindings library
  • Added SC to e2e tests

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • New feature (non-breaking change which adds functionality)

Review

List of tasks the reviewer must do to review the PR

  • Tests
  • Documentation
  • CHANGELOG

Deployment Notes

These should highlight any db migrations, feature toggles, etc.

@waggledans waggledans force-pushed the dans-python-tunnel branch 8 times, most recently from 3d98dfb to b5ec0eb Compare July 17, 2024 22:23
@waggledans waggledans force-pushed the dans-python-tunnel branch from b5ec0eb to a0331a4 Compare July 17, 2024 22:29
@diemol diemol linked an issue Jul 18, 2024 that may be closed by this pull request
@diemol diemol merged commit 476096b into main Jul 18, 2024
1 check passed
@diemol diemol deleted the dans-python-tunnel branch July 18, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tunnelOwner option
2 participants