Java fixes #275
Merged
Java fixes #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
nadvolod
reviewed
Feb 17, 2022
There was a problem hiding this comment.
@titusfortner love the new updates. The code reads so much cleaner. Added one comment. Also, what do you think of those Codacy issues? Many can likely be ignored, but some seem valid to me. Let me know and I can work with you to fix this.
java/main/src/main/java/com/saucelabs/saucebindings/CITools.java
Outdated
Show resolved
Hide resolved
titusfortner
force-pushed
the
java_fixes
branch
4 times, most recently
from
d829aa5 to
3a337f6
Compare
titusfortner
force-pushed
the
java_fixes
branch
3 times, most recently
from
dd06338 to
9aecf9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some generic changes I tweaked while working on other things.
Should be relatively straightforward what's happening here