Skip to content

[java] allow configurations to be used with a browser string value #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

titusfortner
Copy link
Collaborator

I don't know how I feel about this. People doing parameterized platform execution can not currently use the new syntax. This would allow them to do it, but I'm not sure if it is feature creep.

Somewhat tangentially I'm now wondering if we should have put all the methods into SauceOptionsBuilder class instead of having them on SauceOptions directly. I can't remember if we considered this and rejected it or just overlooked it:

SauceOptions options = SauceOptionsBuilder.chrome().setChromeThingOne().setChromeThingTwo().build();
SauceOptions options = SauceOptionsBuilder.usingBrowser("chrome").setChromeThingOne().setChromeThingTwo().build();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant