implement class methods for SauceOptions #266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able parameters are applicable
| @@ -130,8 +158,15 @@ def __getattr__(self, key): | |||
| except KeyError: | |||
| return None | |||
|
|
|||
| def validateOptions(self, kwargs): | |||
There was a problem hiding this comment.
Looks like method needs to be moved up to be defined before __init__
| @@ -15,7 +15,7 @@ | |||
| class SauceSession(): | |||
|
|
|||
| def __init__(self, options=None, data_center='us-west', resolve_ip=False): | |||
| self.options = options if options else SauceOptions() | |||
| self.options = options if options else SauceOptions.chrome() | |||
There was a problem hiding this comment.
This is actually a bit better for being explicit, so good job here
joshgrantsauce
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the Java 1.1.0 code to limit options to only what is valid for the configuration