tests for C# code #121
Open
tests for C# code #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues
======
- Added 2
Complexity increasing per file
==============================
- dotnet/SimpleSauce.Test/SauceOptionsTests.cs 11
Clones added
============
- dotnet/SimpleSauce.Test/SauceOptionsTests.cs 4
See the complete overview on Codacy |
nadvolod
reviewed
Jan 10, 2020
| * A good way for the user to avoid having to know which PlatformName needs to | ||
| * go with which BrowserVersion. I really like that protection and that API. | ||
| * However, I'm cool with simplifying the API and allowing | ||
| * SauceOptions.BrowserVersion = "68"; |
There was a problem hiding this comment.
nadvolod
reviewed
Jan 10, 2020
| public void MergesCapabilitiesFromDictionary() | ||
| { | ||
| //I don't think this is a use case with .NET bindings | ||
| //var capabilities = new Dictionary<string, object>(); |
There was a problem hiding this comment.
nadvolod
reviewed
Feb 19, 2020
| } | ||
|
|
||
| [TestMethod] | ||
| public void ParsesCapabilitiesFromW3CValues() |
There was a problem hiding this comment.
@titusfortner I'm not sure what this test is supposed to be doing? Seems like it's missing some steps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nadvolod please help me update this with the user facing API you want to see for these things.
This is the C# equivalent of the tests in the other bindings. I'm totally cool if we want to have the implementation look different for C# (withs, fluent, enums, whatever); I'm much pickier about the Java code, but this the feature set for options that I'd like to see before beta release.
Let me what you want to see here so I can help with the implementation of it.