Migrate to ts #207

mhan83 · 2023-04-18T17:31:42Z

Convert to typescript.

Defined types for the runner configuration object, but derived the definitions from the implementation instead of from the definitions from saucectl. I went this route for a couple of reasons:

The current config definitions in saucectl is only the most current snapshot, the runner needs to be backwards compatible with old runner config schemas so adhering only to the current def could break backwards compatibility.
I want to change as little implementation as possible to reduce the size of the change set. I didn't want to introduce new bugs during the migration.
There are lots of discrepancies between what's expected by the runner and what's actually delivered by the config from saucectl. Figuring out what's "correct" is a task probably best suited for another PR, imo.

I **think** this will be useful??

Non-exhaustive typing for runner config. Types derived solely from implementation and not from config def in saucectl. The types as-is are not guarnateed to be correct.

Again, types derived from current implementation and not from types definied in saucectl.

Losing easy git blame usage with the conversion so make it a bit more sensical without easy history access.

src/playwright-runner.ts

src/types.ts

src/playwright-runner.ts

Call String as function to do the coercion. Co-authored-by: Alex Plischke <[email protected]>

Keep side effects to a minimum

mhan83 added 30 commits April 13, 2023 09:44

convert constants to ts

e965169

ts-ify project

8298c52

update eslint for typescript support

7711215

Convert utils to ts

af1ca85

update lint

ebcfcb3

Convert reporter to ts

e63274f

convert playwright-recorder to ts

cc7252e

update yargs

0c7159a

bump ts

edf4397

fix compile errors

44bf597

ignore pw config for linting

2df7d98

update tsconfig for actual building

9ac5545

clean up entrypoint

fafab71

make unit tests runnable

736b67d

convert cucumber-runner to ts

48f7226

eslint env to es2022

ad54643

Clean up wonky promise implementation

6a0d291

add types for lodash

db363da

fix export

94c0663

Add type for RunResult

e511200

Convert playwright-runner to ts

a78ba3a

no need to export for entrypoint

19f134f

set endtime after execution

82d4774

build and clean scripts

57552ab

build and copy from lib when bundling

f093ef4

export function under test

fe9c0f3

Remove non-sensical test

8b3c8f1

Emit declaration map

9dd2d2f

I **think** this will be useful??

run build

e228f60

Run a build before bundling

18fe37a

properly reject the promise

abff38b

mhan83 marked this pull request as ready for review April 18, 2023 22:41

mhan83 requested a review from a team as a code owner April 18, 2023 22:41

alexplischke approved these changes Apr 18, 2023

View reviewed changes

mhan83 added 2 commits April 19, 2023 09:17

Main script in package.json needs to be importable

08a1c58

fix silent lint issues

f3cf119

FriggaHel approved these changes Apr 19, 2023

View reviewed changes

tianfeng92 approved these changes Apr 19, 2023

View reviewed changes

mhan83 added 10 commits April 19, 2023 15:09

Type the runner config

4d8b225

Type runCfg args to RunnerConfig

29404c4

update types to reflect actual possible serialization states

6bbc439

Minimal typing for playwright runner config

82f0a37

Non-exhaustive typing for runner config. Types derived solely from implementation and not from config def in saucectl. The types as-is are not guarnateed to be correct.

Add type for CucumberRunnerConfig

11c88c0

Again, types derived from current implementation and not from types definied in saucectl.

Fix conversion of SuiteConfig to cli params

23a4211

remove comments

fab40d2

allow non-string args

39fabba

bit more context for comment

652cf31

Add a bit more context to a note

26c2e4e

Losing easy git blame usage with the conversion so make it a bit more sensical without easy history access.

mhan83 requested review from alexplischke, FriggaHel and tianfeng92 April 21, 2023 19:34

alexplischke reviewed Apr 21, 2023

View reviewed changes

src/playwright-runner.ts Outdated Show resolved Hide resolved

src/playwright-runner.ts Outdated Show resolved Hide resolved

src/types.ts Show resolved Hide resolved

src/types.ts Outdated Show resolved Hide resolved

mhan83 added 3 commits April 21, 2023 14:01

Make testIgnore a string[]

fe09253

cleanup commented code

5495488

restore current functionality

7112941

alexplischke approved these changes Apr 21, 2023

View reviewed changes

src/playwright-runner.ts Outdated Show resolved Hide resolved

src/playwright-runner.ts Show resolved Hide resolved

mhan83 and others added 2 commits April 21, 2023 15:35

Update src/playwright-runner.ts

8dd0bb6

Call String as function to do the coercion. Co-authored-by: Alex Plischke <[email protected]>

Restore old implemenation

857c4b0

Keep side effects to a minimum

mhan83 merged commit 677ec46 into main Apr 21, 2023

mhan83 deleted the DEVX-2240 branch April 21, 2023 23:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to ts #207

Migrate to ts #207

mhan83 commented Apr 18, 2023 •

edited

Loading

Migrate to ts #207

Migrate to ts #207

Conversation

mhan83 commented Apr 18, 2023 • edited Loading

mhan83 commented Apr 18, 2023 •

edited

Loading